Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: template for Gotenberg, a Docker-powered stateless API for PDF files #4759

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

nktnet1
Copy link
Contributor

@nktnet1 nktnet1 commented Jan 6, 2025

Changes

Issues

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Jan 9, 2025
@peaklabs-dev peaklabs-dev self-assigned this Jan 14, 2025
@peaklabs-dev
Copy link
Member

I have tried to test it and it is not working for me. it is getting healthy but does not seem to be working.

Can you please revisit this PR and check if all the necessary options are set by default and also test it with the docker compose empty deploy type to make sure it works.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label Jan 14, 2025
@nktnet1
Copy link
Contributor Author

nktnet1 commented Jan 14, 2025

Hi @peaklabs-dev,

Could you elaborate on what you mean by "not working"?

I've already tested it (both locally and on my production server). Here's a short demo showing the /version and /prometheus/metrics routes:

gotenberg-demo.webm

although all PDF conversion features should work as expected if the right parameters are set.

@peaklabs-dev
Copy link
Member

Ah, I did not notice there was no web GUI on the root of the domain. Can you please also add documentation for this service to make it easier for others in the future.

I will merge it.
Thanks for the PR.

@peaklabs-dev peaklabs-dev merged commit c9ec34e into coollabsio:next Jan 14, 2025
1 check passed
@github-actions github-actions bot removed ⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author. labels Jan 14, 2025
@nktnet1
Copy link
Contributor Author

nktnet1 commented Jan 14, 2025

Thanks @peaklabs-dev

Can you please also add documentation for this service to make it easier for others in the future.

Do you mean somewhere within Coolify? If you could let me know where, I'm happy to contribute this.

If you instead meant on the gotenberg repository, I'm a little hesistant since the author labels it as an "API" service (i.e. backend/no-gui). That said, something similar to this short message on the demo version of the service could be helpful:

image

@peaklabs-dev
Copy link
Member

Yes I mean to our documentation: https://github.com/coollabsio/documentation-coolify

@nktnet1
Copy link
Contributor Author

nktnet1 commented Jan 14, 2025

Pull request coollabsio/documentation-coolify#131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants